Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration 20161123154034 and 20120411123334 #3113

Merged
merged 2 commits into from
Feb 28, 2019

Conversation

spaghetticode
Copy link
Member

@spaghetticode spaghetticode commented Feb 20, 2019

  • migration 20120411123334 was missing a parenthesis causing DB rollback errors
  • migration 20120411123334 is not reversible so change cannot be used

The migration was missing a parenthesis causing DB rollback errors.
The migration was not reversible, so `change` was replaced by `up`.

Having a `down` method does not make much sense, as changing back the field
length to 40 characters does not bring any particular benefit.
@spaghetticode spaghetticode changed the title Fix migration 20161123154034 Fix migration 20161123154034 and 20120411123334 Feb 20, 2019
Copy link
Contributor

@aitbw aitbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@kennyadsl kennyadsl merged commit 12cadc8 into solidusio:master Feb 28, 2019
@kennyadsl kennyadsl deleted the fix-migration-20161123154034 branch February 28, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants