Add migration to drop table/column from 20180710170104
#3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 20, 2019
core/db/migrate/20190220093635_drop_spree_store_credit_update_reasons.rb
Outdated
Show resolved
Hide resolved
core/db/migrate/20190220093635_drop_spree_store_credit_update_reasons.rb
Outdated
Show resolved
Hide resolved
Migration `20180710170104` has been reworked with PR#3109 in order to avoid risky situations for multi-instance Solidus installations. The table `spree_store_credit_update_reasons` and the column `update_reason_id` from table `spree_store_credit_events` can be either still be around (this happens when migration `20180710170104` was run after the mod) or not, so we need to check the presence of both in advance. Also, since on rollback the older version of `20180710170104` would create this table then it cannot be created here in a `down` method. When using the updated version of migration `20180710170104`, the table creation will happen in that migration.
spaghetticode
force-pushed
the
drop-table-from-20180710170104
branch
from
2011a3c to
e08226e
Compare
kennyadsl
approved these changes
Feb 20, 2019
kennyadsl
approved these changes
Feb 25, 2019
jacobherrington
approved these changes
Mar 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration
20180710170104has been reworked with PR #3109 in order to avoidrisky situations for multi-instance Solidus installations.
The table
spree_store_credit_update_reasonsand the columnupdate_reason_idfrom table
spree_store_credit_eventscan be either still be around (thishappens when migration
20180710170104was run after the mod) or not, so weneed to check the presence of both in advance.
Also, since on rollback the older version of
20180710170104would create thistable then it cannot be created here in a
downmethod.When using the updated version of migration
20180710170104, the table creationwill happen in that migration.