Remove unnecessary decimal conversion #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an unnecessary conversion of the count of completed orders (which is always necessarily an integer!) into a decimal number.
brchristian
added a commit
to brchristian/solidus
that referenced
this pull request
Feb 27, 2019
In the backend `User#index` action, we use the [`display_lifetime_value`](https://github.com/solidusio/solidus/blob/master/core/app/models/concerns/spree/user_reporting.rb#L8-L10) helper to get the total value of all _completed_ orders. However, we display the count of _all_ orders, which is inconsistent. This commit changes this behavior and uses the existing [`order_count`](https://github.com/solidusio/solidus/blob/master/core/app/models/concerns/spree/user_reporting.rb#L12-L14) helper. Note that one strange aspect of the current `order_count` helper is that it converts the count to a decimal unnecessarily, which will appear strangely, (e.g., `1.0`) in the backend view. This is fixed in a separate PR by solidusio#3124.
4 tasks
kennyadsl
requested changes
Feb 28, 2019
There was a problem hiding this comment.
Thanks @brchristian, we should probably update related specs as well, right?
|
@kennyadsl That’s a good idea! I’m surprised that current didn’t fail, actually. What if we change from something like this: expect(subject.order_count).to eq BigDecimal(order_count)to something like this: expect(subject.order_count).to eq subject.orders.complete.countIf that seems reasonable to you, I can add a commit to this PR. |
|
@brchristian I'm more for adding the exacxt number that we expect so just leaving: expect(subject.order_count).to eq order_count |
|
@kennyadsl sounds good, I have added the spec to this PR! |
kennyadsl
approved these changes
Mar 7, 2019
jacobherrington
approved these changes
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes an unnecessary conversion of the count of completed orders (which is always necessarily an integer!) into a decimal number.
Checklist: