Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct adjustment type application order in guide #3153

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Correct adjustment type application order in guide #3153

merged 1 commit into from
Mar 26, 2019

Conversation

BenAkroyd
Copy link
Contributor

@BenAkroyd BenAkroyd commented Mar 22, 2019

Description
On the adjustments page of the guide, It states,

By default, tax adjustments are always applied before promotional adjustments.

The opposite is true. See https://github.com/solidusio/solidus/blob/master/core/app/models/spree/order_updater.rb#L111

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

On the adjustments page of the guide, IT states that tax adjustments
are always applied before promo adjustments. The opposite is true.
@kennyadsl
Copy link
Member

@BenAkroyd thanks for the contribution! May I ask how did you verify that? The rest of the sentence makes me think that what is currently written is intentionally done to comply with some tax regulation. Can you help understand the context a little bit more, please?

@BenAkroyd
Copy link
Contributor Author

BenAkroyd commented Mar 22, 2019

@kennyadsl Sure! I've been working on tax integration for several months now with my company, and have had extensive conversations with our lawyer about how things should be calculated, and have seperately confirmed this with her.

@BenAkroyd
Copy link
Contributor Author

The taxation page of the guide correctly lists the order of application https://github.com/solidusio/solidus/blob/master/guides/source/developers/taxation/overview.html.md#order-taxation

@kennyadsl
Copy link
Member

@BenAkroyd oh well, it just makes sense. Thanks!

@BenAkroyd
Copy link
Contributor Author

Also, In err, I included the corrected quote in the pr description, not the quote as it exists on the guide page currently. I have updated it.

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @BenAkroyd! Good catch 🥇

@BenAkroyd
Copy link
Contributor Author

👍 thanks for the ultra-fast feedback!

@kennyadsl kennyadsl merged commit a396be5 into solidusio:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants