Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Tax Categories to discard #3154

Merged

Conversation

kennyadsl
Copy link
Member

Description

It was missing from the work done in #2354.

With the magic of ResourceController, it will start using discard when we perform admin destroys since it now responds to .discard.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change (if needed)

@kennyadsl kennyadsl self-assigned this Mar 26, 2019
It was missing from the work done in solidusio#2354.

With the magic of ResourceController, it will start using
discard when we perform admin destroys, since it now responds
to .discard.
@kennyadsl kennyadsl force-pushed the kennyadsl/discard-tax-categories branch from f5a5505 to 1910b12 Compare March 27, 2019 11:07
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@kennyadsl kennyadsl merged commit 45f58f6 into solidusio:master Apr 3, 2019
@kennyadsl kennyadsl deleted the kennyadsl/discard-tax-categories branch April 3, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants