Hide Master Price input when there's no default price #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
added
type:bug
kennyadsl
force-pushed
the
kennyadsl/discarded-prices
branch
2 times, most recently
from
ad53078 to
94bbe62
Compare
JuanCrg90
approved these changes
Apr 2, 2019
jacobherrington
approved these changes
Apr 2, 2019
kennyadsl
commented
Apr 3, 2019
tvdeyen
approved these changes
Apr 3, 2019
kennyadsl
force-pushed
the
kennyadsl/discarded-prices
branch
2 times, most recently
from
7425b6c to
6c8c4b1
Compare
aitbw
approved these changes
Apr 3, 2019
There was a problem hiding this comment.
Aside from one, non-blocking comment, this is fantastic! Great work @kennyadsl 💪
Right now this method (still not used in the whole codebase) is returning true, even when there is only a default price which has been discarded.
while editing product in admin. This should clarify that there's no current price available for the product using the default pricing configuration.
kennyadsl
force-pushed
the
kennyadsl/discarded-prices
branch
from
6c8c4b1 to
51ce29b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR hides the Master Price input in the Amin Product Edit page when there's no available (not deleted) price for that product's master variant.
closes #1861
closes #1989
Before
👆 Please note that all prices on this product have been deleted,
$999comes from a deleted (discarded) price.After
Checklist: