Fix issue 3164 - generate shipments for backend-added products when necessary #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 3, 2019
spaghetticode
changed the title
spaghetticode
force-pushed
the
spaghetticode/fix-issues-3164
branch
from
4e8dbaa to
50c78cd
Compare
kennyadsl
reviewed
May 3, 2019
There was a problem hiding this comment.
Thanks, @spaghetticode, great work. I just left some comments about things that maybe can be improved or questions, let me know your thoughts!
spaghetticode
force-pushed
the
spaghetticode/fix-issues-3164
branch
from
50c78cd to
97a4c95
Compare
spaghetticode
changed the title
spaghetticode
force-pushed
the
spaghetticode/fix-issues-3164
branch
4 times, most recently
from
111caef to
eb4bd35
Compare
houndci-bot
reviewed
May 7, 2019
spaghetticode
force-pushed
the
spaghetticode/fix-issues-3164
branch
4 times, most recently
from
d606968 to
135510f
Compare
spaghetticode
force-pushed
the
spaghetticode/fix-issues-3164
branch
2 times, most recently
from
d606968 to
98cedb1
Compare
kennyadsl
approved these changes
May 10, 2019
The new method builds missing inventory units for the specified line item. inventory_unit_builder
Sometimes necessity arises to create shipments for an order that is already completed, for example when adding an item in the backend using the `Cart` tab. The existing method `#create_proposed_shipments` cannot be used, as the order is completed, so this new method creates only the missing shipments for the newly added line item.
…t_shipment As sometimes availability matters, it's better to choose an existing shipment that leaves from a stock location that has enough availability for the chosen variant, facilitating warehouse management.
When OrderInventory#determine_target_shipment cannot find a suitable shipment that can accommodate the added variant, then it's necessary to create at least one new shipment for that purpose. This is done by leveraging Order#create_shipments_for_line_item, which creates missing shipments for the newly added items.
spaghetticode
force-pushed
the
spaghetticode/fix-issues-3164
branch
from
98cedb1 to
3847475
Compare
stem
added a commit
to stem/solidus_product_assembly
that referenced
this pull request
Apr 18, 2020
solidusio/solidus#3197 add a mandatory parameter which we should send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #3164. See the issue for further details.
An error occurs when trying to add a product to an existing completed order in the backend and the product stock is not compatible with existing shipments.
This PR adds the ability, when necessary, to generate new shipments also when the order is completed.
Checklist: