Improve jbuilder serialization for Oj gem #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobherrington
approved these changes
May 14, 2019
|
v2.9.1 fixes this problem. No need to backport anything. |
|
@pelargir thanks! I think we can still keep these changes, even it's no more a bug. |
kennyadsl
changed the title
|
@ericsaupe @jacobherrington This is no more strictly required but it's a nice to have if we want to support serializing with |
kennyadsl
changed the title
kennyadsl
force-pushed
the
kennyadsl/jbuilder-2.9.0
branch
from
53d1ca2 to
85141c4
Compare
We were not testing that Float::Infinity serialization is working correctly here.
Be sure we are checking that Float::Infinity is being serialized correctly.
This will be used also in the _product partial. We can't represent Float::INFINITY in JSON: Under JSON this would be NULL Under oj this would error
Float::Infinity serialization is broken with Oj gem, see solidusio#2495 (comment) This commit makes sure we are always nullifying total_on_hand before passing trying to serialize it, if it is a Float::Infinite.
kennyadsl
force-pushed
the
kennyadsl/jbuilder-2.9.0
branch
from
85141c4 to
71a1ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes sure we are always nullifying total_on_hand before passing trying to serialize it, if it is a
Float::Infinity, which was causing issues withoj.Checklist: