[API] Complete Shipments Big json with small json fields #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobherrington
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
I agree with doing this, thanks for fixing this @JuanCrg90!
tvdeyen
reviewed
Jun 12, 2019
Big json should be a super set of Small json. This adds the api/app/views/spree/api/shipments/_smaill.json.jbuilder partial inside api/app/views/spree/api/shipments/_big.json.jbuilder file and remove the duplicated fields.
|
updated @tvdeyen what do you think? |
kennyadsl
added
changelog:solidus_api
JuanCrg90
deleted the
feature/complete-shipments-big-json-small-json-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shipments Big json should be a super set of Small json. This adds in the
https://github.com/solidusio/solidus/blob/e7260a27a7c292908a835f374d5ba73fe7284cd0/api/app/views/spree/api/shipments/_big.json.jbuilder file the missing fields that https://github.com/solidusio/solidus/blob/e7260a27a7c292908a835f374d5ba73fe7284cd0/api/app/views/spree/api/shipments/_small.json.jbuilder contains.
Slack conversation: https://solidusio.slack.com/archives/C0JBKDF35/p1559156244045800
Checklist: