Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Spree::Event guides #3264

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Improve Spree::Event guides #3264

merged 2 commits into from
Jul 16, 2019

Conversation

kennyadsl
Copy link
Member

@kennyadsl kennyadsl commented Jul 10, 2019 •
edited
Loading

Description

This PR re-formats Spree::Event guides page and adds a paragraph that explains how to create subscribers modules, after #3232 changes.

cc @elia

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
    - [ ] I have added tests to cover this change (if needed)

@kennyadsl kennyadsl self-assigned this Jul 10, 2019
tvdeyen
tvdeyen approved these changes Jul 12, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks. A small typo, but otherwise 👍

guides/source/developers/events/overview.html.md Outdated Show resolved Hide resolved
@kennyadsl kennyadsl force-pushed the kennyadsl/improve-events-guides branch from c7ae5da to 295b299 Compare July 12, 2019 12:03
jacobherrington
jacobherrington suggested changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, just a few typos! Let me know what you think.

guides/source/developers/events/overview.html.md Outdated Show resolved Hide resolved
guides/source/developers/events/overview.html.md Outdated Show resolved Hide resolved
guides/source/developers/events/overview.html.md Outdated Show resolved Hide resolved
guides/source/developers/events/overview.html.md Outdated Show resolved Hide resolved
@kennyadsl kennyadsl force-pushed the kennyadsl/improve-events-guides branch from 295b299 to bbe4074 Compare July 15, 2019 10:06
@kennyadsl
Copy link
Member Author

Thanks @jacobherrington, done the proposed changes.

spaghetticode
spaghetticode approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennyadsl thank you for the docs improvement ❤️

jacobherrington
jacobherrington approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

@kennyadsl kennyadsl force-pushed the kennyadsl/improve-events-guides branch from bbe4074 to a26cce8 Compare July 16, 2019 09:44
@kennyadsl kennyadsl merged commit 13ede66 into solidusio:master Jul 16, 2019
@kennyadsl kennyadsl deleted the kennyadsl/improve-events-guides branch July 16, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees

@kennyadsl kennyadsl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennyadsl @tvdeyen @spaghetticode @jacobherrington