-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload new sample images #3270
Upload new sample images #3270
Conversation
e3cd2f1
to
51cab0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is long overdue. Thanks
51cab0f
to
1de4a8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'd merge this after we release 2.9 though.
For the thumbnails issue you raised, I think you are right. Maybe a simple solution could be just hiding "All"
images when a specific variant is selected and that variant has at least one image.
@kennyadsl thanks 👍 The goal, is to have a product page like this: |
We'll need an extensive CHANGELOG entry on this one since users could be relying on those images size and updating Solidus could be dangerous for their layout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look awesome! I agree with merging this after 2.9 👍
Love the refresh! I think it's important for potential users to see a more modern store demo and this is a big step toward that. |
@mfrecchiami can you please rebase this one as well when you have time? (no hurry!) |
1de4a8f
to
d6867d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth noting the changes to the attachment sizes
@mfrecchiami |
Refresh sample images of the store demo, with items branded by Solidus and by a redesigned version of the Ruby logo. Update the image sizes to support the retina screens (is not an appropriate way, maybe we need an helper that load bigger images only on retina screens), except the smaller one preview that is in use on the product page when there are many variants, and in admin area on product list; the issue is that on the product page there is any max-width defined for the thumbnail list items.
d6867d6
to
2116c35
Compare
@kennyadsl now the branch is updated! |
@ericsaupe yes, a CHANGELOG entry for that should be enough, what do you think? If someone is relying on those sizes we can provide instructions to easily change them back. |
The sample images of the online store demo has been updated with new items, branded by Solidus and by a redesigned version of the Ruby logo.
Also image sizes has been changed, to support the retina screens (but maybe an helper that load
@2x
pictures on retina screens only, could be useful).The smaller size called
mini
is still the same: the issue is that on the product page (and somewhere in the backend, also) there is any width or max-width defined, for the thumbnail list item.I noticed that where are more than two colors variant, there is no way to show all thumbnails.
Actually the thumbs are (in order):
the home page product image
the thumbs related to the variant selected by the default Variants input radio
IMO on the product page, it could be better show first the item with the same variation, e.g. color, that is shown on the home page.
For now it is possible only to put same color variation as the first option in Variations list, but then all the thumbs shows the same color, so it seems like duplicated items (until the user select another option).