Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove zombie promotion specs variables #3280

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Remove zombie promotion specs variables #3280

merged 1 commit into from
Jul 23, 2019

Conversation

cedum
Copy link
Contributor

@cedum cedum commented Jul 22, 2019 •
edited by jacobherrington
Loading

While working on a different issue I noticed the following vars seem to be zombies in the promo specs:

  • order: is defined and not used
  • promotable: is already defined in the parent context.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@cedum
Remove zombie promo specs variables
63a1fbc 
Removes `order` and `promotable` variables:
- `order`: is defined and not used
- `promotable`: is already defined in the parent context.
jacobherrington
jacobherrington approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @cedum!

spaghetticode
spaghetticode approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛔🧟@cedum thank you!

@spaghetticode spaghetticode merged commit 6895ecc into solidusio:master Jul 23, 2019
@cedum cedum deleted the cedum/remove-zombie-promo-spec-vars branch July 31, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cedum @spaghetticode @jacobherrington