Use Kaminari's limit_value #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaminari has deprecated `current_per_page` and here we use the new `limit_value` method
spaghetticode
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
@ericsaupe 👍 thank you for removing the deprecation warning!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kaminari has deprecated
current_per_pageand here weuse the new
limit_valuemethodDescription
Debugging some issues with the API we found that the value being returned for
current_per_pagewas not consistent with the params being sent. I found that we are using a deprecated method within Kaminari causing the issue.https://github.com/kaminari/kaminari/blob/master/kaminari-core/lib/kaminari/models/page_scope_methods.rb#L58-L64
Checklist: