Making taxon form to render attachment definitions dynamically #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 21, 2019
| <%= image_tag f.object.icon(:mini) if f.object.icon_present? %> | ||
| <% f.object.class.attachment_definitions.each do |attachment, definition| %> | ||
| <%= f.field_container attachment do %> | ||
| <%= f.label attachment %><br /> |
There was a problem hiding this comment.
Tag br is a void element, it must end with > and not />.
|
@softr8 can you please handle the small nitpick from Hound? Apart from that, I think this is a great improvement, thank you for noticing that there was room for it 👍 ❤️ |
softr8
force-pushed
the
dynamic-taxon-attachment-definitions
branch
from
7cfc7b5 to
746fde7
Compare
kennyadsl
reviewed
Aug 27, 2019
| <%= f.label :icon %><br /> | ||
| <%= f.file_field :icon %> | ||
| <%= image_tag f.object.icon(:mini) if f.object.icon_present? %> | ||
| <% f.object.class.attachment_definitions.each do |attachment, definition| %> |
There was a problem hiding this comment.
Doesn't this work for Paperclip only? I don't think ActiveStorage has a attachment_definitions class method. Maybe we should also make this partial loaded conditionally if we are using the paperclip adapter, similar to what we do for payment method partials. What do you think?
There was a problem hiding this comment.
aha!! Good idea, just adjusted my code to support multiple attachment adapters 👍
softr8
force-pushed
the
dynamic-taxon-attachment-definitions
branch
from
746fde7 to
7bf0161
Compare
kennyadsl
reviewed
Aug 29, 2019
Solidus now allows to inject easily more attachment definitions via configurable modules, if a user adds a new attachment, it would have to override the partial _form to add this new attachment, this change takes all definitions and render the inputs dinalycally, it also allows to specify what partial to render depending on the attachment adapter.
softr8
force-pushed
the
dynamic-taxon-attachment-definitions
branch
from
7bf0161 to
333c192
Compare
kennyadsl
approved these changes
Aug 29, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solidus now allows to inject easily more attachment definitions via
configurable modules (#3237), if a user adds a new attachment, it would be needed
to override the partial _form and add this new attachment, this change
takes all definitions and render the inputs dynamically.
Checklist: