Make all belongs_to associations optional #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this ActiveRecord class setting we make the Rails 5.1 default setting obsolote and turn this off app wide. Rails.application.config.active_record.belongs_to_required_by_default # => true Spree::Base.belongs_to_required_by_default # => false ActiveRecord::Base.belongs_to_required_by_default # => false The fun fact is, the tests all pass with this removed. But this has the potential to break stores if their data is not consistent. We have several options to solve this 1. We tell our users to clean up the database before running the next Solidus update where this included. 2. We include this in a mayor version update 3. We explicitely make all our `belongs_to` associations `optional` I am in favor of the latter
2 tasks
Since Rails 5.1 `belongs_to` associations are required by default. We used to disable this option globally. This hack was removed recently. Since this has the potential to break stores with unconsistent data we need to make all `belongs_to` optional for now.
tvdeyen
force-pushed
the
make-belongs-to-optional
branch
from
6fc24c0 to
56cb3ef
Compare
kennyadsl
approved these changes
Aug 22, 2019
ericsaupe
approved these changes
Aug 22, 2019
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
May 26, 2022
It makes no sense to have dangling option_values without an associated option_type. Ref solidusio#3309 & solidusio#3517
cpfergus1
pushed a commit
to cpfergus1/solidus
that referenced
this pull request
Aug 25, 2022
It makes no sense to have dangling option_values without an associated option_type. Ref solidusio#3309 & solidusio#3517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try of #3260
Since Rails 5.1
belongs_toassociations are required by default. We used to disable this option globally with a ActiveRecord class setting. With this we make the Rails 5.1 default setting obsolote and turn this off app wide.The fun fact is, the tests all pass with this removed. But this has the potential to break stores if their data is not consistent.
We have several options to solve this
belongs_toassociationsoptionalI am in favor of the latter, so I made all
belongs_toassociations optional for now.Description
Checklist: