Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing entries to en yml #3313

Merged
merged 10 commits into from
Aug 27, 2019

Conversation

delphaber
Copy link
Contributor

Description

While doing this PR ( solidusio/solidus_i18n#162 ), I noticed that some translations were missing in solidus en.yml.

I created a single commit per change, but I can rebase and squash them if you prefer :)

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

Sorry, something went wrong.

Fabrizio Monti added 10 commits August 26, 2019 16:36
<th><%= Spree::ShippingMethod.human_attribute_name(:available_to_users) %></th>
`state_id` is alreasy use to define the stock location state (like
Alabama). So I added a `state` translation that means "status". This
pattern is already used in `spree/admin/refund_reasons/index.html.erb`:

`<th><%= Spree::RefundReason.human_attribute_name(:state) %></th>`
`<th><%= Spree::RefundReason.human_attribute_name(:state) %></th>`
Translation is already present
`<th><%= Spree::TaxRate.human_attribute_name(:tax_categories) %></th>`
`<th><%= Spree::Promotion.human_attribute_name(:uses) %></th>`
Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @delphaber! ❤️

@kennyadsl kennyadsl merged commit e6ef9fe into solidusio:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants