Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guides] Add Algolia Docsearch #3324

Merged
merged 5 commits into from
Sep 4, 2019

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Sep 3, 2019

Description

Adds Algolia Docsearch to our guides. Providing a much better search for our guides.

  • Fix mobile portrait viewport
  • Prevent hitting enter from submitting form

Checklist:

Screen Shot 2019-09-03 at 11 33 05

@tvdeyen tvdeyen requested a review from kennyadsl September 3, 2019 09:36
@kennyadsl
Copy link
Member

I'm too happy and I look forward to merging this, thanks @tvdeyen! 🙂

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be working well on the preview.

Nice work @tvdeyen! 👏

Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great feature, thank you @tvdeyen ❤️

@dhonig
Copy link

dhonig commented Sep 3, 2019

Would love to see an alogia extension for solidus, does one exist?

@tvdeyen
Copy link
Member Author

tvdeyen commented Sep 3, 2019

Thanks. I found two things I need to address before merge. Updated the description.

@tvdeyen tvdeyen force-pushed the guides/algolia-docsearch branch from 9e7504b to 6282372 Compare September 3, 2019 20:43
@tvdeyen
Copy link
Member Author

tvdeyen commented Sep 3, 2019

Fixed the autocomplete on small viewports and prevent the form from submitting and navigate to selected search result on enter instead

mobile viewport

@kennyadsl kennyadsl merged commit eff22e6 into solidusio:master Sep 4, 2019
@tvdeyen tvdeyen deleted the guides/algolia-docsearch branch September 4, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants