Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump required ruby version to 2.4 #3337

Merged

Commits on Sep 19, 2019

  1. Bump required ruby version to 2.4.0

    Ruby 2.2 and 2.3 support has ended [1], Rubocop support for 2.2 ended
    and dropping 2.3 as well is close [2].
    
    We also already introduced code that is no more compliant with 2.2.
    
    [1]: https://www.ruby-lang.org/en/news/2019/03/31/support-of-ruby-2-3-has-ended/
    [2]: rubocop/rubocop#6945
    kennyadsl committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    b6dbfea View commit details
    Browse the repository at this point in the history
  2. Bump Rubocop RubyTargetVersion to 2.4

    To reflect the required ruby version of Solidus
    kennyadsl committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    7ef9aab View commit details
    Browse the repository at this point in the history
  3. Update Rubocop to the latest version

    Rubocop recently split some cops into other subgems.
    This commit adds the gems for cops that we were previously using.
    
    This commit also tells HoundCI which Rubocop version to use, and we
    are using 0.72 since it's currently the latest supported version by
    HoundCI. [1]
    
    [1]: http://help.houndci.com/en/articles/2461415-supported-linters
    kennyadsl committed Sep 19, 2019
    Configuration menu
    Copy the full SHA
    3674666 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    699e7a4 View commit details
    Browse the repository at this point in the history