Allow order level promotions with non promotable items #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 25, 2019
| when Spree::Order | ||
| promotable.line_items.joins(:product).where(spree_products: { promotionable: false }).exists? | ||
| # when Spree::Order | ||
| # promotable.line_items.joins(:product).where(spree_products: { promotionable: false }).exists? |
There was a problem hiding this comment.
Layout/CommentIndentation: Incorrect indentation detected (column 6 instead of 8).
still needs tests and a configuration that allows not changing existing stores behavior, see solidusio#1925
kennyadsl
force-pushed
the
fix-order-level-promotion-with-non-promotable-items
branch
from
6617bf8 to
ef5edd1
Compare
deodad
reviewed
Nov 13, 2019
| when Spree::Order | ||
| promotable.line_items.joins(:product).where(spree_products: { promotionable: false }).exists? | ||
| # when Spree::Order | ||
| # promotable.line_items.joins(:product).where(spree_products: { promotionable: false }).exists? |
There was a problem hiding this comment.
Another option could be to perform a check like so:
promotable.line_items.any? &&
!promotable.line_items.joins(:product).where(spree_products: { promotionable: true }).any?
There was a problem hiding this comment.
Thanks for your suggestion. Do you mean that we could perform this check instead of removing this code?
|
Closing this. It tries to fix a bug but I don't know if it's still the best way to handle the problem now. This spike will still be attached to the main issue, which will be kept open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧🚧🚧
Description
This PR allows applying order-level promotions to orders with some non-promotionable line items.
Those line items will not be taken into account in promotion computations since store owners could have their good reasons to exclude them from being promotionable.
ref: #1925, #1437 and #3339
WIP This is just a spike, it still needs:
Thanks, @cedum for the help in the in-depth analysis.
Checklist: