Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused sample images #3397

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Remove unused sample images #3397

merged 1 commit into from
Oct 24, 2019

Conversation

JDutil
Copy link
Contributor

@JDutil JDutil commented Oct 23, 2019 •
edited
Loading

A recent update of the project's sample product branding added new
images, and product names to the seeds. These images are no longer
being used, and can be removed.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)

@JDutil JDutil mentioned this pull request Oct 23, 2019
Merged
4 tasks
@JDutil
Remove unused sample images
a44f831 
A recent update of the project's sample product branding added new
images, and product names to the seeds:
solidusio@8221dcb

These images are no longer being used, and can be removed.
@JDutil JDutil force-pushed the remove-old-sample-images branch from 25c9da6 to a44f831 Compare October 23, 2019 23:31
tvdeyen
tvdeyen approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

spaghetticode
spaghetticode approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JDutil thank you 👍

@jacobherrington jacobherrington merged commit 2aedd8e into solidusio:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JDutil @tvdeyen @spaghetticode @jacobherrington