Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change variable names to enhance readability in helpers #3399

Merged
merged 1 commit into from
Oct 26, 2019
Merged

Change variable names to enhance readability in helpers #3399

merged 1 commit into from
Oct 26, 2019

Conversation

juliannatetreault
Copy link
Contributor

Description

Related: #3294

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

jacobherrington
jacobherrington approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a PR! 🚀

Looks good to me 👍

tvdeyen
tvdeyen approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks. Will this conflict with #3400 though?

@JDutil
Copy link
Contributor

JDutil commented Oct 25, 2019

@tvdeyen I think only 1 line conflicts as its variant_with_prices instead of simply variant, but I can fix that if this is merged first.

@juliannatetreault
Copy link
Contributor Author

@tvdeyen I think only 1 line conflicts as its variant_with_prices instead of simply variant, but I can fix that if this is merged first.

Okay, sounds great; thanks!

kennyadsl
kennyadsl approved these changes Oct 26, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @juliannatetreault!

@kennyadsl kennyadsl merged commit 95ae9b9 into solidusio:master Oct 26, 2019
@kennyadsl kennyadsl mentioned this pull request Oct 26, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@jacobherrington jacobherrington jacobherrington approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

@JDutil JDutil JDutil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juliannatetreault @JDutil @tvdeyen @kennyadsl @houndci-bot @jacobherrington