Update one letter variables to be more descriptive #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 24, 2019
core/spec/models/spree/return_item/exchange_variant_eligibility/same_product_spec.rb
Show resolved
Hide resolved
houndci-bot
reviewed
Oct 24, 2019
houndci-bot
reviewed
Oct 24, 2019
tvdeyen
approved these changes
Oct 25, 2019
|
@kennyadsl rebased. As for the git conflict concerns they're certainly true, but I'm also not really sure how to accomplish this change without essentially tearing the band aid off and dealing with the pain. The only other way to handle it would be to leave the code as is until the code is touched as part of another PR and not merging them without fixing any 1 letter variables they touch. I could help fix PRs with conflicts if they turn up though. I suspect there will be fewer of them than feared, but I'm not really sure. |
Throughout Solidus' codebase there are many one-letter variables. These are not ideal as they are not expressive and meaningful for human beings.
We want to name rescued errors as error not simply e in order to clear up one-letter variables that are not communicative.
This makes code easier to read using if rather than unless conditional.
It's okay to skip model validation to setup a spec.
kennyadsl
approved these changes
Oct 28, 2019
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
May 11, 2020
The variable has been missed in solidusio#3400
5 tasks
kennyadsl
added a commit
to nebulab/solidus
that referenced
this pull request
May 11, 2020
The variable has been missed in solidusio#3400
kennyadsl
added a commit
that referenced
this pull request
May 13, 2020
The variable has been missed in #3400
mamhoff
pushed a commit
to mamhoff/solidus
that referenced
this pull request
Feb 1, 2021
The variable has been missed in solidusio#3400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throughout Solidus' codebase there are many one-letter variables.
These are not ideal as they are not expressive and meaningful for human
beings.
This is a continuation of work done by @mkoltonski in #3304 with the feedback from @dportalesr incorporated.
Fixes #3294
Checklist: