Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix in_taxons scope when taxon is an ActiveRecord::Base #3617

Merged
merged 1 commit into from
May 13, 2020
Merged

Fix in_taxons scope when taxon is an ActiveRecord::Base #3617

merged 1 commit into from
May 13, 2020

Conversation

kennyadsl
Copy link
Member

@kennyadsl kennyadsl commented May 11, 2020 •
edited
Loading

Description

The variable has been missed in #3400

We also need to backport this in 2.10 and release a new version.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@kennyadsl kennyadsl added type:bug Error, flaw or fault Needs Backport labels May 11, 2020
@kennyadsl kennyadsl self-assigned this May 11, 2020
@aldesantis aldesantis requested a review from a team May 11, 2020 12:17
@kennyadsl kennyadsl force-pushed the kennyadsl/fix-in_taxons-scope branch from 3b35196 to 971a053 Compare May 11, 2020 12:46
@kennyadsl kennyadsl merged commit 43cacf4 into solidusio:master May 13, 2020
@kennyadsl kennyadsl deleted the kennyadsl/fix-in_taxons-scope branch May 13, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmacdougall gmacdougall gmacdougall approved these changes

@jarednorman jarednorman jarednorman approved these changes

@aldesantis aldesantis aldesantis approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees

@kennyadsl kennyadsl

Labels
type:bug Error, flaw or fault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kennyadsl @spaghetticode @aldesantis @jarednorman @gmacdougall