Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing admin store credit reasons tab not expanded #3401

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Fixing admin store credit reasons tab not expanded #3401

merged 1 commit into from
Oct 25, 2019

Conversation

softr8
Copy link
Contributor

@softr8 softr8 commented Oct 24, 2019 •
edited
Loading

Description
Left menu was not expanded when trying to manage store credit reasons

Before
image

After

image

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@softr8
Fixing admin store credit reasons tab not expanded
c21b084 
Left menu was not expanded when trying to manage store credit reasons
@softr8 softr8 force-pushed the fix/admin-store-credit-tab branch from d3986c9 to c21b084 Compare October 24, 2019 17:23
jacobherrington
jacobherrington approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for making this PR @softr8 💯

tvdeyen
tvdeyen approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much.

I almost forgot how beautiful the new admin UI is

@tvdeyen tvdeyen merged commit 7286e36 into solidusio:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

@JDutil JDutil JDutil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@softr8 @JDutil @tvdeyen @jacobherrington