Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md [ci skip] #3402

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Update CONTRIBUTING.md [ci skip] #3402

merged 1 commit into from
Oct 25, 2019

Conversation

juliannatetreault
Copy link
Contributor

@juliannatetreault juliannatetreault commented Oct 24, 2019 •
edited
Loading

Description

  • Clarifies examples
  • Fixes grammatical inconsistencies

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@juliannatetreault
Update CONTRIBUTING.md [ci skip]
6cc7895 
- Clarifies examples
- Fixes grammatical inconsistencies
jacobherrington
jacobherrington approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR @juliannatetreault 🚀

tvdeyen
tvdeyen approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

spaghetticode
spaghetticode approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliannatetreault thank you 👍

@tvdeyen tvdeyen merged commit 517388a into solidusio:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

@JDutil JDutil JDutil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juliannatetreault @JDutil @tvdeyen @spaghetticode @jacobherrington