Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list of events fired by default to Guides/Events #3430

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Add list of events fired by default to Guides/Events #3430

merged 1 commit into from
Nov 18, 2019

Conversation

j-sm-n
Copy link

@j-sm-n j-sm-n commented Nov 16, 2019

Description

This PR adds the current list of events that Solidus fires off on production to the 'Events' overview guide.

Ref: #3414

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

tvdeyen
tvdeyen approved these changes Nov 16, 2019
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. That's helpful

kennyadsl
kennyadsl approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @j-sm-n!

@kennyadsl kennyadsl merged commit fd49d21 into solidusio:master Nov 18, 2019
@j-sm-n j-sm-n deleted the add-supported-events-documentation-3414 branch November 18, 2019 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-sm-n @tvdeyen @kennyadsl