Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guides: do not escape markdown headers in custom renderer #3432

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Guides: do not escape markdown headers in custom renderer #3432

merged 1 commit into from
Nov 20, 2019

Conversation

filippoliverani
Copy link
Contributor

Description
Browsing the developers guide I found some html entities rendered inside headings tags.

Screenshot 2019-11-19 at 15 48 49

This PR updates CustomMarkdownRenderer to avoid to render html entities by considering source markdown headers safe.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have attached screenshots to this PR for visual changes (if needed)

Do not escape markdown haders in custom renderer
6318c5e 
Padrino::Helpers::TagHelpers#content_tag escapes by default the content
block. We can assume that markdown header is safe and avoid to escape
it so that html entities won't be rendered.
@filippoliverani filippoliverani changed the title Do not escape markdown haders in custom renderer Guides: do not escape markdown haders in custom renderer Nov 19, 2019
@filippoliverani filippoliverani changed the title Guides: do not escape markdown haders in custom renderer Guides: do not escape markdown headers in custom renderer Nov 19, 2019
spaghetticode
spaghetticode approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filippoliverani thank you 👍

kennyadsl
kennyadsl approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @filippoliverani!

@kennyadsl kennyadsl merged commit ce7f6e5 into solidusio:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filippoliverani @spaghetticode @kennyadsl