Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rubocop version #3449

Merged
merged 1 commit into from
Dec 11, 2019
Merged

update rubocop version #3449

merged 1 commit into from
Dec 11, 2019

Conversation

hmtanbir
Copy link
Contributor

@hmtanbir hmtanbir commented Dec 8, 2019 •
edited
Loading

Description
Update rubocop from 0.72 to 0.75

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@hmtanbir
Copy link
Contributor Author

hmtanbir commented Dec 8, 2019

@kennyadsl, @elia Would you please check my PR?

@kennyadsl
Copy link
Member

Hey there, thanks for the contribution. Can you please explain which issue are you trying to solve here? I’m ok updating Rubocop but this should not be necessary since bundler already takes the last available version in the 0.x series with what we have now.

Thanks!

@hmtanbir
Copy link
Contributor Author

hmtanbir commented Dec 9, 2019 •
edited
Loading

Recently, I have updated some view files and got some rubocop attention because some syntax has been changed in rubocop 0.77.0 , after updating my rubocop version, it fixed automitacally, so I have made this PR , rubocop changelog

@filippoliverani
Copy link
Contributor

@hmtanbir I had the same problem and I noticed that Hound does not support Rubocop 0.77 yet, meanwhile we clould lock rubocop gem to 0.75 and update .hound.yml accordingly, WDYT?

@kennyadsl
Copy link
Member

Thank you @hmtanbir, can you just squash commits into a single one, please?

@hmtanbir hmtanbir force-pushed the update-rubocop-version branch from 8f3b6c6 to be72515 Compare December 9, 2019 15:13
@hmtanbir
Copy link
Contributor Author

hmtanbir commented Dec 9, 2019 •
edited
Loading

@kennyadsl @filippoliverani Would you please check it now, thanks!

kennyadsl
kennyadsl approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ericsaupe
ericsaupe approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennyadsl kennyadsl merged commit c13dc85 into solidusio:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsaupe ericsaupe ericsaupe approved these changes

@mushfiqweb mushfiqweb mushfiqweb approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hmtanbir @kennyadsl @filippoliverani @mushfiqweb @ericsaupe