Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace map.flatten with flat_map #3491

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Replace map.flatten with flat_map #3491

merged 1 commit into from
Jan 29, 2020

Conversation

grzegorz-jakubiak
Copy link
Contributor

Description
flat_map is 1.6 faster than map.flatten - Enumerable#map...Array#flatten vs Enumerable#flat_map

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

tvdeyen
tvdeyen reviewed Jan 26, 2020
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Would you please update the commit message so it includes the same information as the pull request?

@grzegorz-jakubiak grzegorz-jakubiak force-pushed the feature/flatten-map-to-flat-map branch from 488f235 to dd5caca Compare January 26, 2020 21:34
@grzegorz-jakubiak
Copy link
Contributor Author

@tvdeyen done!

kennyadsl
kennyadsl approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is great!

@aldesantis
Copy link
Member

@grzegorz-jakubiak looking great, and could you please update the commit? 🙏

@kennyadsl kennyadsl merged commit 4df3f05 into solidusio:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvdeyen tvdeyen tvdeyen left review comments

@gmacdougall gmacdougall gmacdougall approved these changes

@aldesantis aldesantis aldesantis approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grzegorz-jakubiak @aldesantis @tvdeyen @kennyadsl @gmacdougall