Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure payment methods are ordered correctly #3506

Merged

Conversation

AlistairNorman
Copy link
Contributor

Description

Previously we were not respecting the payment method order in the admin. This orders them and tests that they are being ordered properly.

The payment method order was previously not respected in the admin. This
orders the payment methods.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlistairNorman 👍

@jacobherrington jacobherrington merged commit 65ffffe into solidusio:master Feb 6, 2020
@jarednorman jarednorman deleted the order-payment-methods branch February 6, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants