Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log basic response information #3508

Merged
merged 2 commits into from
Feb 25, 2020
Merged

Only log basic response information #3508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63169fe
Only log basic response information
JDutil Feb 6, 2020
fa36d24
Refactor payment processing specs
JDutil Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 30 additions & 10 deletions core/app/models/spree/payment/processing.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,22 +204,42 @@ def protect_from_connection_error
end

def gateway_error(error)
if error.is_a? ActiveMerchant::Billing::Response
text = error.params['message'] || error.params['response_reason_text'] || error.message
elsif error.is_a? ActiveMerchant::ConnectionError
text = I18n.t('spree.unable_to_connect_to_gateway')
else
text = error.to_s
end
logger.error(I18n.t('spree.gateway_error'))
logger.error(" #{error.to_yaml}")
raise Core::GatewayError.new(text)
message, log = case error
when ActiveMerchant::Billing::Response
[
error.params['message'] || error.params['response_reason_text'] || error.message,
basic_response_info(error)
]
when ActiveMerchant::ConnectionError
[I18n.t('spree.unable_to_connect_to_gateway')] * 2
else
[error.to_s, error]
end

logger.error("#{I18n.t('spree.gateway_error')}: #{log}")
raise Core::GatewayError.new(message)
end

# The unique identifier to be passed in to the payment gateway
def gateway_order_id
"#{order.number}-#{number}"
end

# The gateway response information without the params since the params
# can contain PII.
def basic_response_info(response)
{
message: response.message,
test: response.test,
authorization: response.authorization,
avs_result: response.avs_result,
cvv_result: response.cvv_result,
error_code: response.error_code,
emv_authorization: response.emv_authorization,
gateway_order_id: gateway_order_id,
order_number: order.number
}
end
end
end
end
Loading