Scope image by product_id or variant_id in ImagesController #3510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image route is under the product and variant resources: `/api/products/:product_id/images/:id` `/api/variants/:variant_id/images/:id` When reading or perfoming any change on the product/variant image, the controller should scope the product or the variant when finding the image id. The risk in only find by image id is to delete or read an image which belongs to another product. The route path give an expectation that the controller must meet: a request to a product or variant image.
SamuelMartini
force-pushed
the
SamuelMartini/scope_product_images
branch
from
5aeab81 to
30b9732
Compare
spaghetticode
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The image route is under the product and variant resources:
/api/products/:product_id/images/:id/api/variants/:variant_id/images/:idWhen reading or performing any change on the product/variant image, the controller should scope the product or the variant when finding the image id.
The risk in only find by image id is to delete or read an image that belongs to another product.
The route path gives an expectation that the controller must meet: a request to a product or variant image.
NOTE: The product scope was present in the controller but removed by this pr #1580. Not clear how that removal was needed but putting back the scope now is not breaking any spec and the functionality in admin still working.
Checklist: