Memoize Spree::User#wallet method #3513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are already using memoization on some
Spree::Order
methods:and
Spree::User#wallet
seems a good candidate to memoize.Without memoization every time someone calls this method a new instance of
Spree::Wallet
is created but I think we should interact ever with the same instance, It seems logical to me that a user has just one wallet, this way the code reflect the reality and It also improves performance and memory usage.Checklist: