Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace wrong key and add parameters in product taxons endpoint doc #3531

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Replace wrong key and add parameters in product taxons endpoint doc #3531

merged 1 commit into from
Mar 4, 2020

Conversation

SamuelMartini
Copy link
Contributor

Description
Spree::Api::TaxonsController#products accepts id param to find the taxon and not taxon_id.

The products action also accept simple param to filter product data and return a leaner response.

Checklist:

@SamuelMartini
Replace wrong key and add parameters in product taxons endpoint doc
274efe6 
Spree::Api::TaxonsController#products accept `id` param to find the taxon.

The products action also accept `simple` param to filter product data.
kennyadsl
kennyadsl approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SamuelMartini

@kennyadsl kennyadsl added Code Review Needed changelog:solidus_api Changes to the solidus_api gem labels Mar 3, 2020
spaghetticode
spaghetticode approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Samuel 🎉

@kennyadsl kennyadsl merged commit 669ba5f into solidusio:master Mar 4, 2020
@kennyadsl kennyadsl deleted the SamuelMartini/fix_taxon_products_stoplight_doc branch March 4, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
changelog:solidus_api Changes to the solidus_api gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuelMartini @spaghetticode @kennyadsl