Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate reimbursement hooks #3541

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Deprecate reimbursement hooks #3541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions core/app/models/spree/reimbursement.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,20 @@ def perform!(created_by: nil)
if unpaid_amount_within_tolerance?
reimbursed!
Spree::Event.fire 'reimbursement_reimbursed', reimbursement: self
if reimbursement_success_hooks.any?
Spree::Deprecation.warn \
"reimbursement_success_hooks are deprecated. Please remove them " \
"and subscribe to `reimbursement_reimbursed` event instead", caller(1)
end
reimbursement_success_hooks.each { |hook| hook.call self }
else
errored!
Spree::Event.fire 'reimbursement_errored', reimbursement: self
if reimbursement_failure_hooks.any?
Spree::Deprecation.warn \
"reimbursement_failure_hooks are deprecated. Please remove them " \
"and subscribe to `reimbursement_errored` event instead", caller(1)
end
reimbursement_failure_hooks.each { |hook| hook.call self }
end

Expand Down