Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve gemspecs of solidus and subcomponents #3546

Merged
merged 7 commits into from
Mar 11, 2020

Conversation

kennyadsl
Copy link
Member

Description

This PR refactors gemspecs of Solidus and all its subcomponents mainly to make them uniform.
Having them in the same format makes it easier to find information for users that are navigating and comparing them since they already know where to find information.

It also removes specs for the gem builds, since they are not used and increase the package size without any real benefits.

For what is worth, here's the exact saving:

# With tests

 12K    solidus
508K    core
108K    api
880K    backend
188K    frontend
9.0M    sample

Total
10.696K - (1.696K without sample)

# Without tests

 12K    solidus
300K    core
 48K    api
816K    backend
144K    frontend
9.0M    sample

Total
10.320K - (1.320K without sample)

With a size decrease of 22% if we don't consider solidus_sample

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • [ ] I have updated Guides and README accordingly to this change (if needed)
  • [ ] I have added tests to cover this change (if needed)
  • [ ] I have attached screenshots to this PR for visual changes (if needed)

Sorry, something went wrong.

There are no file of that type in the solidus_api gem
This commit just changes the inner block variable `gem` to `s`,
to reflect what we do in other gemspecs.

It also reorder items so it's easy to find gemspecs pieces where
we have them in the gemspec of the other components.
To reflect the position we have in other gemspecs
This option tells which system requirements are needed
in order for Solidus to work. 'none' isn't really telling
anything.
@kennyadsl kennyadsl self-assigned this Mar 10, 2020
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @kennyadsl 👍

Copy link
Contributor

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

@kennyadsl kennyadsl merged commit e038e9f into solidusio:master Mar 11, 2020
@kennyadsl kennyadsl deleted the kennyadsl/improve-gemspecs branch March 11, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants