Replace Paranoia methods with Discard equivalents #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're replacing Paranoia with Discard. This replaces paranoia' method 'with_deleted' with 'with_discarded' which is the equivalent method provided by discard.
We're replacing Paranoia with Discard. This replaces paranoia' method 'deleted?' with 'discarded?' which is the equivalent method provided by discard.
houndci-bot
reviewed
Mar 13, 2020
We're replacing Paranoia with Discard. This replaces paranoia' method 'only_deleted' with 'discarded' which is the equivalent method provided by discard.
cedum
force-pushed
the
replace-paranoia-methods
branch
from
e8db716 to
9f5ed14
Compare
gmacdougall
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the usage of Paranoia methods with their Discard equivalent methods:
.with_deleted=>.with_discarded.only_deleted=>.discarded#deleted?=>#discarded?This has been extracted from the #3488 PR. After some feedback, I'm extracting the non-breaking bits into separate PRs, so we can merge them without having to wait for Solidus v3.
Once merged, I'll rebase and revisit #3488 to definitely remove Paranoia as a dependency from Solidus v3.
Checklist: