Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-alphabetize app configuration prefs #3556

Merged

Conversation

elia
Copy link
Member

@elia elia commented Mar 13, 2020

Description

Also added a couple of comments to clearly mark where the
alphabetization should end.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@elia elia force-pushed the elia/reorder-app-configuration-prefs branch from 58c435d to 2604013 Compare March 13, 2020 15:39
Also added a couple of comments to clearly mark where the
alphabetization should end. There were some "sections" within the list
of prefs but the ending of each one wasn't very clear and they ended
up mixed with other stuff.
@elia elia force-pushed the elia/reorder-app-configuration-prefs branch from 2604013 to e77c2ae Compare March 13, 2020 16:03
@elia elia marked this pull request as ready for review March 23, 2020 17:52
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elia!

@kennyadsl kennyadsl merged commit 78ccf7f into solidusio:master Apr 8, 2020
@kennyadsl kennyadsl deleted the elia/reorder-app-configuration-prefs branch April 8, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants