Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the duplicated active scope and name validations #3629

Merged
merged 2 commits into from
May 22, 2020
Merged

Remove the duplicated active scope and name validations #3629

merged 2 commits into from
May 22, 2020

Conversation

halilim
Copy link

@halilim halilim commented May 20, 2020

Description

It's already defined in Spree::NamedType. Fixes #3628.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Remove the duplicated active scope
5207d23 
It's already defined in `Spree::NamedType`. Fixes solidusio#3628.
@aldesantis
Copy link
Member

@halilim thanks! Should we also remove the validations on :name? I see those are also defined in Spree::NamedType.

Remove the duplicated validation
18992d3 
Similar to the `active` scope, this too is already defined in `Spree::NamedType`
@halilim
Copy link
Author

halilim commented May 20, 2020

@aldesantis indeed, thanks! I was so focused that I missed the forest for the tree :) Removed.

@halilim halilim changed the title Remove the duplicated active scope Remove the duplicated active scope and name validations May 20, 2020
@aldesantis aldesantis requested a review from a team May 20, 2020 16:37
tvdeyen
tvdeyen approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kennyadsl kennyadsl merged commit dd77373 into solidusio:master May 22, 2020
@kennyadsl
Copy link
Member

Thanks! 🎉

@halilim halilim deleted the patch-1 branch May 29, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldesantis aldesantis aldesantis approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated scope in StoreCreditReason
4 participants
@halilim @aldesantis @kennyadsl @tvdeyen