[Backend] More precise cancan validations for some resource links #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given we're in an area specific for a given user, when we want to create a new order, it must be for that specific user.
houndci-bot
reviewed
Jun 5, 2020
spaghetticode
force-pushed
the
memotoro/pr-2823
branch
from
2d0f1d9 to
9c4e891
Compare
jarednorman
approved these changes
Jun 5, 2020
present) for the following resources in the backend: * Spree::Image * Spree::Order * Spree::Payment * Spree::ReturnAuthorization
spaghetticode
force-pushed
the
memotoro/pr-2823
branch
from
9c4e891 to
48f0ed5
Compare
spaghetticode
changed the title
jarednorman
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This the continuation of the work done by @memotoro that I was unable to continue on the original PR.
I added some integration tests in order to verify permissions work as expected, and I reintroduced
the user id specification to some new order links as the context implies we're going to create an order for the given user.
Checklist: