Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] Fix Square Logos appearance #3702

Merged

Conversation

michaelmichael
Copy link
Contributor

Description
Ref #3692

This just adds an explicit height to the .brand-link div in admin. This height is controlled by the $main-header-height variable. Then it sets the image to have a max-width/height of 100%. It should prevent logos of any size or aspect ratio from overflowing and preventing access to the ui. See square, tall, and wide logos below:

Screen Shot 2020-07-10 at 3 50 29 PM

Screen Shot 2020-07-10 at 3 53 23 PM

Screen Shot 2020-07-10 at 3 53 55 PM

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but otherwise I'm fine with this solution. Could probably be done slightly more cleanly with flexbox if you wanted to take a stab at that, though.

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but do you mind squashing the two commits together for a clean git history?

@michaelmichael michaelmichael force-pushed the fix-square-logos-in-admin-3692 branch from 11e704e to 02b3182 Compare July 14, 2020 21:43
@michaelmichael
Copy link
Contributor Author

Ok, squashed into a single commit.

Copy link
Member

@aldesantis aldesantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelmichael!

@spaghetticode spaghetticode changed the title Fix Square Logos in Admin [Admin] Fix Square Logos appearance Jul 17, 2020
@spaghetticode spaghetticode merged commit 4076b64 into solidusio:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants