Respect current ability in users controllers #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Admin user's index was displaying a list with all users even if current ability states it shouldn't be accessible Now only users that are allowed to be accessed will be displayed on the list
Admins users able to create and update a user could inject any stock location id to user params, and the user would have it assigned to it even if the admin don't have the ability to manage it.
Admins users able to create and update a user could inject any role id to user params, and the user would have it assigned to it even if the admin don't have the ability to manage it.
jarednorman
approved these changes
Aug 16, 2020
There was a problem hiding this comment.
@igorbp thanks for these fixes 🎉
It looks good to me, I left only one question about a change that I'm not 100% sure about.
| if user_params[:stock_location_ids] | ||
| @user.stock_locations = | ||
| Spree::StockLocation.accessible_by(current_ability).where(id: user_params[:stock_location_ids]) | ||
| end |
There was a problem hiding this comment.
I think the behavior was slightly changed. The old code always set the user stock locations, also when the parameter was not present, in that case by stock locations to an empty array. This does not happen anymore here. Is this change wanted?
There was a problem hiding this comment.
This is a good question. I took this decision because with these changes admins that can't manage stock locations would remove user's stock locations since the params wouldn't be there.
spaghetticode
approved these changes
Aug 21, 2020
aldesantis
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Admin users were able to see users, roles, and stock locations that they don't have permission to manage in admin users index and form. This fixes those authorization inconsistencies reported in issue #3668.
:spree_role_idsand:stock_locations_idsparams were still being assigned to the user.Checklist: