Make payment.rb methods more concise

[brchristian]

Description

In payment.rb, the source_required? method uses the foo.present? && foo.bar pattern, which can more concisely be expressed in Ruby >= 2.3 using the safe navigation operator as foo&.bar.

Likewise, the profiles_supported? method uses the foo.respond_to?(:bar) && foo.bar pattern, which can more concisely be expressed using Rails's try method as foo.try(:bar).

[brchristian]

One additional thought is that we could also prepend with !! if we wanted to coerce the return value to a boolean.

[jarednorman]

That might be worth it to be extra safe. You never know whether someone might be relying on == false or something. 😅

[brchristian]

@jarednorman Done! 👍

[spaghetticode]

@brchristian thanks! 👍