Fix rails 61 deprecations #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> DEPRECATION WARNING: Class level methods will no longer inherit scoping from `*` in Rails 6.1. To continue using the scoped relation, pass it into the block directly. To instead access the full set of models, as Rails 6.1 will, use `Spree::Taxon.default_scoped`. Note: This only fixes the warning originating from Spree. There are still some but they originate in `acts_as_list` and `awesome_nested_set`
houndci-bot
reviewed
Aug 22, 2020
| @@ -134,7 +134,7 @@ def permalink_part=(value) | |||
|
|
|||
| def touch_ancestors_and_taxonomy | |||
| # Touches all ancestors at once to avoid recursive taxonomy touch, and reduce queries. | |||
| self.class.where(id: ancestors.pluck(:id)).update_all(updated_at: Time.current) | |||
| self.class.default_scoped.where(id: ancestors.pluck(:id)).update_all(updated_at: Time.current) | |||
There was a problem hiding this comment.
Rails/SkipsModelValidations: Avoid using update_all because it skips validations.
jarednorman
approved these changes
Aug 23, 2020
aldesantis
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two Rails 6.1 deprecation warnings:
*in Rails 6.1.' warningNote: The second warning still occurs in several tests but originates from the
acts_as_listandawesome_nested_setgem