Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't combine splat and hash, just use the attribute form #3742

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Don't combine splat and hash, just use the attribute form #3742

merged 1 commit into from
Aug 28, 2020

Conversation

marcrohloff
Copy link
Contributor

Description

Instead of double-splatting a hash use attributes directly

@aldesantis
Copy link
Member

Hey @marcrohloff, thanks for your contribution!

@stefano-sarioli could you take a look at this on Friday, since you made the original changes? 🙏

@stefano-sarioli
Copy link
Contributor

@aldesantis looks good to me, I actually find this form more readable.
Nice catch, thank you @marcrohloff 😄

@aldesantis
Copy link
Member

I'm re-running the failed jobs.

@aldesantis aldesantis merged commit f1f75db into solidusio:master Aug 28, 2020
@stefano-sarioli stefano-sarioli mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman approved these changes

@aldesantis aldesantis aldesantis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcrohloff @aldesantis @stefano-sarioli @jarednorman