Replace --auto-accept with --interactive #3743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auto-accept erroneously assumed acceptance where the install generator actively asks for content in several places.
Squiggle heredocs were introduced in Ruby 2.3, so we can finally use them at large.
It wasn't doing a thing.
Add a description and default value, that is overridden when solidus_auth_devise will be the auth extension.
The whole class is marked as @Private, so it's fine not to deprecate.
|
Hey, @elia 👋 Is this PR still valid? |
|
@waiting-for-dev I guess the fundamental issue wasn't solved in the meantime so I would say yes, we should still streamline the generator and allow it to run both interactively and unattended. |
|
Thanks, @elia! If I get it well, it's more of a semantic renaming than a behavior change, right? I'm ok with that; I think it makes sense. When you have a second, could you rebase it from master, please? 🙏 Also, I'm not sure if it can be already marked as ready for review. |
|
Hey @elia, I'll close it for now, but if you find the time to keep working on it I'll be more than happy to reopen 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current solidus install generator will ask for a number of things unless
--auto-acceptis provided. Since many of the things asked are not simple yes/no questions, and by default Rails doesn't require any interaction when generating a new app, we should move to an opt-in--interactiveflag.The current PR only switches to the new CLI option and cleans up the generator to make it more maintainable by solidus core and usable by end-users.
Checklist: