Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in comment in navigation_helper.rb #3770

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Fix typo in comment in navigation_helper.rb #3770

merged 1 commit into from
Sep 24, 2020

Conversation

brchristian
Copy link
Contributor

@brchristian brchristian commented Sep 23, 2020 •
edited
Loading

Description
Fixes a typo in comment in navigation_helper.rb.

No CI should be needed.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@aldesantis aldesantis requested a review from a team September 24, 2020 07:21
spaghetticode
spaghetticode approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brchristian thanks 👍

@spaghetticode spaghetticode merged commit 02d6a00 into solidusio:master Sep 24, 2020
@brchristian brchristian deleted the patch-7 branch September 24, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldesantis aldesantis aldesantis approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brchristian @spaghetticode @aldesantis