Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make spelling of 'email' consistent #3780

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Make spelling of 'email' consistent #3780

merged 1 commit into from
Sep 30, 2020

Conversation

brchristian
Copy link
Contributor

@brchristian brchristian commented Sep 27, 2020 •
edited
Loading

Description
I noticed that the codebase and English localization consistently use the spelling "Email" (or "email"), except for in one place where it used the spelling "E-Mail". For the sake of consistency, this PR changes the one hyphenated spelling so that we are consistent across all of Solidus.

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@aldesantis aldesantis requested a review from a team September 28, 2020 07:16
spaghetticode
spaghetticode approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brchristian thank you 👍

tvdeyen
tvdeyen approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@kennyadsl kennyadsl merged commit 20f57f2 into solidusio:master Sep 30, 2020
@kennyadsl kennyadsl added changelog:solidus_core Changes to the solidus_core gem and removed Needs Core Team Review labels Sep 30, 2020
@brchristian brchristian deleted the email_spelling branch September 30, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldesantis aldesantis aldesantis approved these changes

@spaghetticode spaghetticode spaghetticode approved these changes

@tvdeyen tvdeyen tvdeyen approved these changes

Assignees
No one assigned
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brchristian @tvdeyen @spaghetticode @aldesantis @kennyadsl