Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Rails master builds on CircleCI #3796

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Oct 13, 2020

They are failing all the time and should not fail a PR. Since we
do not know how to send neutral status checks we should remove
them.

Checklist:

They are failing all the time and should not fail a PR. Since we
do not know how to send neutral status checks we should remove
them.
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can reintroduce this check once we have the green check green again, or find a way to report a less aggressive state in the GitHub checks.

@stem
Copy link
Contributor

stem commented Oct 13, 2020

Hey @tvdeyen, what do you think about running specs against rails master on the master branch once per week ?
I'm not a CircleCI configuration expert, but it seems doable and would enable us to see if it works with rails master without compromising build status of solidus' PRs.

@tvdeyen
Copy link
Member Author

tvdeyen commented Oct 13, 2020

Hey @tvdeyen, what do you think about running specs against rails master on the master branch once per week ?
I'm not a CircleCI configuration expert, but it seems doable and would enable us to see if it works with rails master without compromising build status of solidus' PRs.

Yes, but we need to make sure that the README badge is not effected by this. Currently we point this to the latest master branch build.

@spaghetticode spaghetticode merged commit 67bbedd into solidusio:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants