Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reassign image to another variant in admin #3810

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix reassign image to another variant in admin #3810

merged 1 commit into from
Nov 17, 2020

Conversation

felixyz
Copy link
Contributor

@felixyz felixyz commented Oct 26, 2020

Description
This fixes a regression that makes it impossible to re-assign an image to another variant once it has been assigned to a specific variant.

Fixes #3804

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@felixyz felixyz force-pushed the fix-image-reassign branch from ccaef75 to 8e24c09 Compare October 26, 2020 11:58
kennyadsl
kennyadsl approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @felixyz!

@kennyadsl kennyadsl changed the title [fix] Ability to reassign image to another variant Fix reassign image to another variant in admin Oct 28, 2020
@kennyadsl kennyadsl added type:bug Error, flaw or fault changelog:solidus_backend Changes to the solidus_backend gem Needs Backport labels Oct 28, 2020
@kennyadsl kennyadsl modified the milestones: 3.0.0, 2.11 Oct 28, 2020
@kennyadsl kennyadsl merged commit 17227b0 into solidusio:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@jarednorman jarednorman jarednorman approved these changes

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
changelog:solidus_backend Changes to the solidus_backend gem type:bug Error, flaw or fault
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Cannot re-assign images to another variant of the same product
4 participants
@felixyz @kennyadsl @jarednorman @houndci-bot